Skip to content

Fix: improve join chunks to prevent memory exhaustion when joining large files #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lohanidamodar wants to merge 2 commits into from
Closed

Fix: improve join chunks to prevent memory exhaustion when joining large files #157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf18810
fix: enhance joinChunks method to improve chunk file handling
lohanidamodar Feb 23, 2026
343d063
fix: update joinChunks method to open destination file in write mode …
lohanidamodar Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/Storage/Device/Local.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,20 +184,34 @@ public function uploadData(string $data, string $path, string $contentType, int
private function joinChunks(string $path, int $chunks)
{
$tmp = \dirname($path).DIRECTORY_SEPARATOR.'tmp_'.\basename($path).DIRECTORY_SEPARATOR.\basename($path).'_chunks.log';

$dest = \fopen($path, 'wb');
if ($dest === false) {
throw new Exception('Failed to open destination file '.$path);
}

for ($i = 1; $i <= $chunks; $i++) {
$part = dirname($tmp).DIRECTORY_SEPARATOR.pathinfo($path, PATHINFO_FILENAME).'.part.'.$i;
$data = file_get_contents($part);
if (! $data) {
$src = \fopen($part, 'rb');
if ($src === false) {
\fclose($dest);
throw new Exception('Failed to read chunk '.$part);
}

if (! file_put_contents($path, $data, FILE_APPEND)) {
if (\stream_copy_to_stream($src, $dest) === false) {
\fclose($src);
\fclose($dest);
throw new Exception('Failed to append chunk '.$part);
}
\fclose($src);
\unlink($part);
}

\fclose($dest);
\unlink($tmp);
\rmdir(dirname($tmp));
if (! \rmdir(\dirname($tmp))) {
\trigger_error('Failed to remove temporary chunk directory '.dirname($tmp).' (chunk log: '.$tmp.')', E_USER_WARNING);
}
}

/**
Expand Down