Skip to content

Conversation

admiralakber
Copy link

@admiralakber admiralakber commented Sep 16, 2025

Closes #830

  • Update submodule llama.cpp to b6482 (3d4053f)
  • Built and tested locally via Nix on Linux
  • Bump crate versions: llama-cpp-sys-2 and llama-cpp-2 to 0.1.123

Notes:

  • No changes to CI workflows or .github/*

@MarcusDunn
Copy link
Contributor

If you could revert the version changes, those are handled automatically through actions on release.

@MarcusDunn
Copy link
Contributor

It also looks like this needs a cargo fmt

@admiralakber admiralakber force-pushed the chore/update-llama-cpp-b6482 branch 2 times, most recently from a10d514 to 3ccd7fc Compare September 16, 2025 23:37
@admiralakber admiralakber force-pushed the chore/update-llama-cpp-b6482 branch from 3ccd7fc to 87e9d2b Compare September 16, 2025 23:39
@admiralakber
Copy link
Author

No worries, all done.

I do notice that llama-cpp-2/Cargo.toml references llama-cpp-2-sys by version 0.1.113 which is behind what's defined in llama-cpp-sys-2/Cargo.toml is that intentional?

Thanks for the feedback and help.

@MarcusDunn
Copy link
Contributor

MarcusDunn commented Sep 17, 2025

Thanks!

Everything should be as it was set in #822. (one version ahead of latest on crates.io), if that was changed inadvertently:
a) thanks for catching it! would have had be confused come release time
b) please adjust back!

Also the cargo lock seems incorrect - you may have to revert those changes manually as well.

@admiralakber
Copy link
Author

admiralakber commented Sep 17, 2025

Hey Marcus,

Cargo.lock should be fixed now referencing 0.1.122 as per #822

Also in the latest commit, you should see specifically under dependencies where it seemed to lag behind. Is this indicating a potential tweak needed for the github action?

@MarcusDunn
Copy link
Contributor

MarcusDunn commented Sep 19, 2025

I'm not sure, I'll take a closer look when I do the next release (once this is merged), I think everything is correct as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unknown model architecture: 'gemma-embedding'
2 participants