fix AltAddMethod.mdx and related explanation #1497
Open
+125
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymkx
force-pushed
the
20250327-fix-mfa-initial
branch
from
a5043e1 to
5206a6d
Compare
|
🚀 Deployed on https://deploy-preview-1497--utelecon.netlify.app |
haxibami
reviewed
May 31, 2025
There was a problem hiding this comment.
見ました。SVGを使うのは結構テクニカルな気がしますが、環境・パラメータを変えても問題なく動いているようなので、良いと思います。
修正自体はこのままマージしても問題ないと思うのですが、<ArrowOverlay /> コンポーネントは今後も別の箇所で活用できそうなので、src/components/README.md に軽くドキュメンテーションがあってもよいかなと思いました。
関連して一点気になったのは、defaultWidth / defaultHeight がハードコードされている点です。1280 x 720 以外の解像度の画像に対してこのコンポーネントを利用する際、x, y を相対指定（%）したときの表示が意図した通りではなくなると思うのですが、これは一旦放置という感じですかね……？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-1497--utelecon.netlify.app/utokyo_account/mfa/initial/?alt=ms_auth#alternative
「Microsoft Authenticator」、「その他の認証アプリ」、「電話番号」の各タブの修正です。