Modify Calculation Function of Ground Image Position in Telescope #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dify_observe_ground_position_deviation_func
Hiro-0110
requested review from
200km,
conjikidow,
seki-hiro,
suzuki-toshihir0 and
t-hosonuma
and removed request for
a team
…dify_observe_ground_position_deviation_func
Hiro-0110
changed the title
Hiro-0110
changed the title
seki-hiro
requested changes
Jun 6, 2024
Member
seki-hiro
left a comment
seki-hiro
left a comment
There was a problem hiding this comment.
計算時間の求め方以外は、アルゴリズム面に問題はないと思います。単位が実態と異なる変数や、少し読みにくい部分があるので、修正してもらえると嬉しいです。
Member
|
[Q] s2e-aobcの方にも似たコメントをつけましたが、こちら元々一般性の高い 本来はこのtelescopeをベースにTDI用のより特殊な |
…dify_observe_ground_position_deviation_func
Member
|
@Hiro-0110 修正ありがとうございます。アルゴリズム面は問題ないと思います。 実装場所はここではなくなるということだったので、誤ってマージすることがないように、approveはしないでおきますね。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Mention any issues that this pull request is related (e.g., #1). Consider using the
developmentfield if you want to close the issue automatically when this pull request is merged.Description
撮像時間幅のの開始時刻付近, 中央時刻付近, 終了時刻付近における, センサ中央に対応する地表点, センサy最大位置に対応する地表点, センサy最小位置に対応する地表点の動きを計算してグラフ化するようにした
Test results
Impact
Describe the scope of influence of the changes, e.g.,
The behavior of feature ** changes.Supplementary information
Provide any supplementary information.