Skip to content

Fixes one illegal and one unnecessary special case of the start symbol productions #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jurgenvinju wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Open

Fixes one illegal and one unnecessary special case of the start symbol productions #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/analysis/typepal/Collector.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,7 @@ default void collect(Tree currentTree, Collector c){
case "label":
{ p = currentTree.prod; collect(appl(prod(p.def.symbol, p.symbols, p.attributes/*, src=getLogicalLoc(currentTree)*/), currentTree.args), c); }
case "start":
{ p = currentTree.prod; collect(appl(prod(p.def.symbol, p.symbols, p.attributes/*, src=getLogicalLoc(currentTree)*/), currentTree.args), c); }
collect(currentTree.args[1], c);
Copy link
Copy Markdown
Member Author

@jurgenvinju jurgenvinju Apr 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we make sure that in collectAndSolve down in TypePal.rsc we don't need to special-case for start/top

case "sort":
{ args = currentTree.args;
nargs = size(args);
Expand Down
1 change: 0 additions & 1 deletion src/analysis/typepal/TypePal.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ extend analysis::typepal::Version;
// collectAndSolve shorthand for a common, simple, scenario

TModel collectAndSolve(Tree pt, TypePalConfig config = tconfig(), str modelName = "no-name"){
if(pt has top) pt = pt.top;
Copy link
Copy Markdown
Member Author

@jurgenvinju jurgenvinju Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this (type-incorrect) special case is not needed due to the default collect handler in Collector.rsc

c = newCollector(modelName, pt, config);
collect(pt, c);
return newSolver(pt, c.run()).run();
Expand Down
Loading