Ability to run parsers for symbols like A*, A+, {A ","}+ and A? without introducing a dummy non-terminal - #2809
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
=========================================
- Coverage 46% 45% -1%
- Complexity 6776 6791 +15
=========================================
Files 844 844
Lines 67103 68785 +1682
Branches 10022 10023 +1
=========================================
+ Hits 30903 31334 +431
- Misses 33828 35080 +1252
+ Partials 2372 2371 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
47dbf95 to
8fea7a7
Compare
|
… including the right traces (was a TODO and needed to understand the changes to the parsers I am making
|
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
Looks good, but there's some things that need to be cleaned up.
| { | ||
| "type": "java", | ||
| "name": "$GENERATED_PARSER$244372483", | ||
| "request": "launch", | ||
| "mainClass": "org.rascalmpl.test.parser.$GENERATED_PARSER$244372483", | ||
| "projectName": "rascal" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "$GENERATED_PARSER$279786030", | ||
| "request": "launch", | ||
| "mainClass": "org.rascalmpl.test.parser.$GENERATED_PARSER$279786030", | ||
| "projectName": "rascal" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "TopLevelStarListEmpty", | ||
| "request": "launch", | ||
| "mainClass": "org.rascalmpl.test.parser.TopLevelStarListEmpty", | ||
| "projectName": "rascal" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "TopLevelStarList", | ||
| "request": "launch", | ||
| "mainClass": "org.rascalmpl.test.parser.TopLevelStarList", | ||
| "projectName": "rascal" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "NonTerminalStarListEmpty", | ||
| "request": "launch", | ||
| "mainClass": "org.rascalmpl.test.parser.NonTerminalStarListEmpty", | ||
| "projectName": "rascal" | ||
| }, |
There was a problem hiding this comment.
as this shows up for everyone, shall we drop these from the file?
| } | ||
| } | ||
| catch (ImplementationError e) { | ||
| throw e; |
There was a problem hiding this comment.
can we document the reason why the REPL needs to not catch this error? (but rethrow it without any message/integration with the jline3 expectations?)
There was a problem hiding this comment.
I don't remember why this is again. could be debug code.
There was a problem hiding this comment.
yeah, that would make more sense indeed, let's get it our of there again 👍🏼
| <version>0.43.0-RC13-SNAPSHOT</version> | ||
| <version>0.43.0-RC16-PREVIEW-REGULAR-PARSERS-SNAPSHOT</version> | ||
| <packaging>jar</packaging> | ||
|
|
There was a problem hiding this comment.
this version change should not be merged to mainbranch, it shoudl be reset to RC13-SNAPSHOT
4 participants
parserandparsersfeature in ParseTree.rsc