Rewrite rename framework #547
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toinehartman
force-pushed
the
fix/rename-refactoring/maintainability
branch
from
d56c958 to
580c61c
Compare
toinehartman
commented
Dec 19, 2024
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/rascal/RascalLanguageServices.java
Outdated
Show resolved
Hide resolved
|
…tainability-fields Rename: fields
…g/maintainability
…tainability-typeparams Rename: type parameters
…tainability-grammar-augmentation Rename: implement grammars
…tainability-error-handling Rename: parse/type error handling
…-refactoring/maintainability-escaping
…tainability-escaping Rename: fix escaping of qualified names
…g/maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements the rename refactoring using the language-parametric renaming framework https://github.com/SWAT-engineering/rascal-rename-framework/. It aims to increase readability, maintainability and performance and almost completely rewrites the existing implementation.
Work included in this PR (separately reviewed):