fix: Docker user permissions when writing to data.txt #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twaslowski
changed the title
Closed
also only build stable on tag pushes; build canary images by default
twaslowski
force-pushed
the
feat/docker-compose
branch
from
2d1fc0c to
b7ba429
Compare
twaslowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #136, the
data.txtfile is created if it does not exist at /app/data.txt (or wherever theDATAenvironment variable points to). This can cause failures due to lacking permissions. This PR fixes the Dockerfile to make sure that the user running the container entrypoint has permissions to create/app/data.txt.Additionally, I've added a
docker-compose.yamlthat speeds up first steps; it behaves pretty much the same as what was previously outlined in the README.