Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugging Face Transformers integration #75

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

eustlb
Copy link
Contributor

@eustlb eustlb commented Dec 17, 2024

Note

This PR is marked as WIP as the underlying Transformer’s PR should be merged before merging this one.

Hey there,

Thanks for the great work! It’s truly going to benefit the community 🤗
I’ve been working on integrating the model into Transformers: huggingface/transformers#34784
This integration will allow users to benefit from the improvements brought by the underlying features of the GenerationMixin‘s generate method and all its generation strategies, as well as the FA2 implementation, support for batch generation, torch.compile, and more. Additionally, this will increase the model’s visibility, as we are planning communications around both the Transformers and Transformers.js integrations.

If that aligns with your plans, we would greatly appreciate a review of the modeling file (/src/transformers/models/moonshine/modeling_moonshine.py) from your side.

Thanks for giving me access to the Hub org, I'll update the necessary from my own model repos:
https://huggingface.co/eustlb/moonshine-tiny
https://huggingface.co/eustlb/moonshine-base

@keveman
Copy link
Contributor

keveman commented Dec 17, 2024

@eustlb Thanks a lot for putting together moonshine support for the transformers repo, looks like so much effort went into that. But it will be a great reference for me going forward to add other tweaks that are in the works. I read through huggingface/transformers#34784 as best as I can. t looks good, although I have to confess my non-familiarity of Transformers code base could mean I might have missed to spot some opportunities for improvement. I would defer to your judgement on that. Please let me know if I can do anything else to speedup merging of that PR.

@eustlb
Copy link
Contributor Author

eustlb commented Dec 18, 2024

No worries, it's mostly for you to know it's there! I've sent a slack invite to your gmail for further discussions 🤗

@eustlb eustlb changed the title [WIP] Hugging Face Transformers integration Hugging Face Transformers integration Jan 10, 2025
@eustlb
Copy link
Contributor Author

eustlb commented Jan 10, 2025

Ready to be merged 😊

@njeffrie
Copy link
Contributor

njeffrie commented Jan 13, 2025

It looks like we have a bug with our presubmit - I'm going to bypass it for now since you're not touching anything relevant to the style check.

@njeffrie njeffrie merged commit 8c381be into usefulsensors:main Jan 14, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants