Skip to content

chore: Re-enable Solidity to ink! contract call integration test #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidsemakula
Copy link
Collaborator

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

Description

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented May 1, 2025

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with 0 and comparing them to ink! master:

Show Results
Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 20.807 20.807 0 0
call-runtime 2.194 2.194 0 0
combined-extension 2.51 2.51 0 0
complex-storage-structures 4.296 4.296 0 0
conditional-compilation 1.448 1.448 0 0
contract-invocation 7.936 7.936 0 0
contract-invocation/contract1 1.844 1.844 0 0
contract-invocation/contract2 1.804 1.804 0 0
contract-invocation/virtual_contract 4.222 4.222 0 0
contract-invocation/virtual_contract_ver1 1.852 1.852 0 0
contract-invocation/virtual_contract_ver2 1.864 1.864 0 0
contract-storage 18.471 18.471 0 0
contract-terminate 1.414 1.414 0 0
contract-transfer 3.038 3.038 0 0
contract-xcm 28.206 28.206 0 0
cross-contract-calls 8.774 8.774 0 0
cross-contract-calls/other-contract 1.524 1.524 0 0
custom-allocator 3.056 3.056 0 0
custom-environment 2.23 2.23 0 0
debugging-strategies 4.086 4.086 0 0
dns 8.058 8.058 0 0
e2e-call-runtime 1.673 1.673 0 0
e2e-runtime-only-backend 2.249 2.249 0 0
erc1155 19.167 19.167 0 0
erc20 9.446 9.446 0 0
erc721 11.034 11.034 0 0
events 5.982 5.982 0 0
flipper 1.597 1.597 0 0
incrementer 1.279 1.279 0 0
lang-err/call-builder 8.456 8.456 0 0
lang-err/call-builder-delegate 3.135 3.135 0 0
lang-err/constructors-return-value 2.225 2.225 0 0
lang-err/contract-ref 7.626 7.626 0 0
lang-err/integration-flipper 1.795 1.795 0 0
lazyvec 4.854 4.854 0 0
mapping 9.489 9.489 0 0
mother 13.646 13.646 0 0
multi-contract-caller 12.782 12.782 0 0
multi-contract-caller/accumulator 1.138 1.138 0 0
multi-contract-caller/adder 3.129 3.129 0 0
multi-contract-caller/subber 3.137 3.137 0 0
multisig 24.388 24.388 0 0
own-code-hash 2.204 2.204 0 0
payment-channel 11.014 11.014 0 0
psp22-extension 7.382 7.382 0 0
rand-extension 3.451 3.451 0 0
runtime-call-contract 1.527 1.527 0 0
sol-cross-contract 5.517 5.517 0 0
sol-cross-contract/other-contract-sol 2.474 2.474 0 0
sol_encoding 2.403 2.403 0 0
solidity-calls-flipper 7.615 7.615 0 0
sr25519-verification 0.957 0.957 0 0
static-buffer 2.502 2.502 0 0
storage-types 15.915 15.915 0 0
trait-dyn-cross-contract-calls 3.579 3.579 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.589 1.589 0 0
trait-erc20 9.746 9.746 0 0
trait-incrementer 1.659 1.659 0 0
upgradeable-contracts/delegator 5.877 5.877 0 0
upgradeable-contracts/delegator/delegatee 2.62 2.62 0 0
upgradeable-contracts/delegator/delegatee2 2.621 2.621 0 0
upgradeable-contracts/set-code-hash 1.503 1.503 0 0
upgradeable-contracts/set-code-hash-migration 1.503 1.503 0 0
upgradeable-contracts/set-code-hash-migration/migration 1.67 1.67 0 0
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.701 1.701 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.463 1.463 0 0
wildcard-selector 2.787 2.787 0 0

Link to the run | Last update: Sun May 4 14:14:57 CEST 2025

@davidsemakula davidsemakula force-pushed the semakula/sol-ink-call branch from 630edb5 to 77e00fd Compare May 4, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant