-
Notifications
You must be signed in to change notification settings - Fork 454
Combine storage traits and derives into single crate #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1389 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 190 190
Lines 5873 5873
=======================================
Hits 4195 4195
Misses 1678 1678 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks clearly now=)
I like that Storable
in the right place right now. And I definitely like definition of the AccountId
, Hash
in the ink_ptimitives
=)
Follow up to #1331. Reviewers don't be alarmed this is just moving a bunch of stuff around.
This PR:
ink_storage_traits
crateStorable
definition and derive there (together with other traits)ink_env
It is to make life easier for storage derive macro crate identifiers in #1223.
ink_primitives
contains theStorable
trait definition and derive.ink_storage
->ink_env
, soink_env
cannot depend onink_storage
(circular dependency)