Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column order in generated CSV #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexanderAA
Copy link
Contributor

No description provided.

@AlexanderAA
Copy link
Contributor Author

The issue remains, but this is not the correct fix. Therefore removing the request.

@achlipala
Copy link
Collaborator

What's the issue? Can you provide a test case with expected output?

@AlexanderAA
Copy link
Contributor Author

Answer to #7 explains how to define any desired column ordering.
My patch helps to output columns in order (as opposed to reversed). Please consider merging.

@AlexanderAA AlexanderAA reopened this Mar 22, 2016
@achlipala
Copy link
Collaborator

I'm hesitant to merge that changeset, because the current version is going to create much more efficient compiled code, considering the optimizations in the compiler. What might be called for is more documentation in csv.urs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants