kt_http.py crashes when we are getting an empty key value #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al set of read/insert/delete complete.
…he HTTP transport.
Minimal support for the KT binary protocol.
Do not choke on unicode keys or dropped connections.
…nce, if installed.
Performance improvement for the JSON packer (using "python-cjson")
Reverted README to reStructuredText, needed for PyPI.
Replace json for simplejson, it is better supported and seemingly as fast
…-ASCII characters. Fix set() slowness over HTTP when using KT_PACKER_STRING and unicode values. Match binary protocol's set()/get() return values with the HTTP protocol (boolean instead of int).
…). All tests successful on both Python 2.7 and 3.2.
Fixes and a "play_script" method.
Binary data packer and support for custom packers
modelines at the bottom with a generic "# EOF - filename.py" comment. Move packer constants to a separate file to avoid duplication. Dropped the "picker_protocol" parameter, use a custom packer. Fix integer database IDs in the HTTP protocol.
Minor reorganization. Fixes.
Better error handling/reporting
…thon releases show no difference.
Identifier cleanups and default DB ids.
Library uses exceptions instead of a (silent) error object for error reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using python-kyototycoon library and I found this little situation which I think as an issue:
my kyototycoon was running using a normal initialization:
$ktserver -port 2001 -li
after that, i did:
$ ktremotemgr set -port 2001 a "" ("" an empty string)
it doesn't give any error and after that, typing:
$ ktremotemgr get -port 2001 a
(empty string)
it returns an empty string (like i set)
I supose that python-kyototycoon should has the same behavior, but it doesn't because pickles.loads(data) throw and EOFError, crashing my script
But if the original behavior of kyoto is to return an empty string, should python return the same value?
What do you think?