Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sessia-dev
Copy link

No description provided.

@sessia-dev
Copy link
Author

Im fix current requirements of package

"license": "Apache-2.0",
"require": {
"php": "^8.1",
"symfony/framework-bundle": "^6.1",
"yokai/doctrine-value-object": "^0.0.3"
"symfony/framework-bundle": "^6.1|^7.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Composer syntax for the OR constraint is || instead of |:
https://getcomposer.org/doc/articles/versions.md#version-range

"symfony/framework-bundle": "^6.1",
"yokai/doctrine-value-object": "^0.0.3"
"symfony/framework-bundle": "^6.1|^7.0",
"yokai/doctrine-value-object": "^0.0.3|^0.2"
Copy link
Member

@sshymko sshymko Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include the ^0.1 version to not have the version gap?

@sshymko
Copy link
Member

sshymko commented Sep 6, 2024

@sessia-dev
Thanks for your contribution! Could you please address a few CR notes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants