Smart::NumberInput #579
Merged
Smart::NumberInput #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenCoogan
changed the base branch from
master
to
feature/jace-experience-system
OwenCoogan
force-pushed
the
oc/DRA-3559
branch
from
4db387f to
ed03e50
Compare
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 28. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Miexil
approved these changes
Oct 8, 2025
Comment on lines
+48
to
+67
| loading: { | ||
| description: '[OPTIONAL] Shows loading state with animated placeholder', | ||
| table: { | ||
| type: { | ||
| summary: 'boolean' | ||
| }, | ||
| defaultValue: { summary: 'false' } | ||
| }, | ||
| control: { type: 'boolean' } | ||
| }, | ||
| placeholder: { | ||
| description: '[OPTIONAL] Placeholder text shown during loading state', | ||
| table: { | ||
| type: { | ||
| summary: 'string' | ||
| }, | ||
| defaultValue: { summary: 'undefined' } | ||
| }, | ||
| control: { type: 'text' } | ||
| }, |
There was a problem hiding this comment.
I'm confused, does this actually work ? I thought you mentioned it was not possible in the PR description
aprentout
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Quick component for smart number input.
No loading state placeholder ( lack of space ) , the smart gradient is applied when loading state goes back to false, same pattern as other components
Related to: #
What are the observable changes?
Good PR checklist