Feature/trinity test rt397972 diffing drop status complete #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- additional packages and - moved env variables value
The functions that execute the SQL statemetns all do exactly the same thing, but with different parameters. So I'm refactoring that data into a data structre, and just writing the code once.
The previous hard coded working_directory variable had a trailing folder separator. But the directory name generated by TemporaryDirectory does not have a separator, leading to the script failing. While here I also fixed the name of the file, as I'd forgotten to add the .csv file extension, and I corrected the mode used when opening the csv file, so it's writeable.
I think I had gotten the column handling wrong in the SIS_Datatype class. And I found that cur.fetch() doesn't exist, hence changed it to cur.fetchall().
Modify post_data so that a variety of parameters are sent when in diffing mode. Also extend main() to prompt for those parameters.
And store into the global dict the diffing parameters we will use.
This is my re-write of the sis/canvas_synergetic_integration/main.py to implement diffing
I'm also changing the wording slightly on a log message, as I think this phrasing is slightly more correct.
Minor fixes for Trinity test
Normally this iterates over all the defined views. This allows an operator to optionally name the views to run on.
Trinity test
…ration While working this I've also tried to improve some comments, and I've stopped using "from import" style of imports.
The zip file was not being created in the temporary directory. Instead it was being created in the operators working directory.
Trinity test
Trinity test
Set a diffing identifier that's based on the view name.
Rachelle Ferrer suggested the diffing_drop_status parameter be changed from inactive to deleted_last_completed. She explained that this option is not technically a status, but combines the deleted and completed statuses. If there is at least one other active enrollment in the course, enrollments marked as deleted_last_completed will be deleted. If it is the last enrollment in the course, the deleted_last_completed enrollment will be set as complete. Rachelle Ferrer also recommended diffing is only done for enrolments, but this script has not yet been modified to account for that recommendation.
Change deleted_last_completed parameter to deleted_last_completed
…d confirmed working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading an update for canvas_test update. This script was tested and proven to work last Friday afternoon in conjunction with RT397972.