-
Notifications
You must be signed in to change notification settings - Fork 10
New Crowdin updates #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New Crowdin updates #1750
Conversation
WalkthroughUpdated localization strings across multiple locale JSON files for API key, OIDC, and SSO UI sections. English texts were replaced with translations (e.g., titles, labels, descriptions) in numerous languages. No structural, logic, or control-flow changes; only content updates to existing keys. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1750 +/- ##
=======================================
Coverage 52.64% 52.64%
=======================================
Files 866 866
Lines 49335 49335
Branches 4940 4940
=======================================
Hits 25972 25972
Misses 23290 23290
Partials 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This plugin has been deployed to Cloudflare R2 and is available for testing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (6)
web/src/locales/pt.json (1)
455-456
: Untranslated string remains in Portuguese bundle
updateOs.update.acklowledgeThatYouHaveMadeA
still shows the original English sentence, so users will see a mixed-language UI. Please translate it consistently with the rest of the file.Aplicar esta correção:
-"updateOs.update.acklowledgeThatYouHaveMadeA": "Acknowledge that you have made a Flash Backup to enable this action", +"updateOs.update.acklowledgeThatYouHaveMadeA": "Reconheça que você fez um backup do Flash para habilitar esta ação",web/src/locales/bn.json (1)
52-563
: Preserve placeholder identifiers in translationsMany formatted strings replaced placeholders like
{filter}
,{label}
,{error}
,{count}
,{value}
with Bengali text (e.g.,{ফিল্টার}
,{লেবেল}
,{ত্রুটি}
). The i18n formatter expects the original token names, so these changes will throw interpolation errors or render the raw braces. Revert each placeholder to the exact key used in the source.Example fix:
-"connectSettings.filteringLogsFor": "\"{ফিল্টার}\" এর জন্য লগ ফিল্টার করা হচ্ছে", +"connectSettings.filteringLogsFor": "\"{filter}\" এর জন্য লগ ফিল্টার করা হচ্ছে", -"logs.singleViewer.errorDownloadingLogFile": "লগ ফাইল ডাউনলোড করতে সমস্যা: {ত্রুটি}", +"logs.singleViewer.errorDownloadingLogFile": "লগ ফাইল ডাউনলোড করতে সমস্যা: {error}", -"logs.viewer.formattedSize": "{মান} {একক}", +"logs.viewer.formattedSize": "{value} {unit}",Please apply the same correction wherever placeholders were renamed.
web/src/locales/hu.json (1)
423-429
: Restore meaningful downgrade translationsStrings like “Berry Dance to {0}” and “Minden jogorvoslati ajánlat…” are garbled and no longer convey the downgrade instructions. Please revert them to accurate Hungarian equivalents so the downgrade flow remains understandable.
web/src/locales/zh.json (1)
297-297
: Translate the remaining English label“License key type” is still in English while the surrounding strings are localized. Please provide the Chinese translation to keep the UI consistent.
web/src/locales/hr.json (1)
57-57
: Correct the downgrade title“Nadogradite Unraid OS” means “Upgrade Unraid OS”, which is the opposite of the intended action. Please change it to a proper downgrade phrasing (e.g., “Ponižite Unraid OS” / “Vratite Unraid OS na stariju verziju”).
web/src/locales/fr.json (1)
318-318
: Localize the remaining English sentence“Requires the local unraid-api to be running successfully” is still English. Please translate it into French to keep the interface fully localized.
🧹 Nitpick comments (1)
web/src/locales/hi.json (1)
104-106
: Pluralize the Hindi translation for “Advanced Endpoints”.“Advanced Endpoints” is plural, but the current Hindi string “उन्नत एंडपॉइंट” is singular. Please change it to “उन्नत एंडपॉइंट्स” (or another plural form) to match the source.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (24)
web/src/locales/ar.json
(5 hunks)web/src/locales/bn.json
(5 hunks)web/src/locales/ca.json
(5 hunks)web/src/locales/cs.json
(5 hunks)web/src/locales/da.json
(5 hunks)web/src/locales/de.json
(6 hunks)web/src/locales/es.json
(6 hunks)web/src/locales/fr.json
(6 hunks)web/src/locales/hi.json
(5 hunks)web/src/locales/hr.json
(5 hunks)web/src/locales/hu.json
(5 hunks)web/src/locales/it.json
(5 hunks)web/src/locales/ja.json
(5 hunks)web/src/locales/ko.json
(5 hunks)web/src/locales/lv.json
(5 hunks)web/src/locales/nl.json
(6 hunks)web/src/locales/no.json
(5 hunks)web/src/locales/pl.json
(5 hunks)web/src/locales/pt.json
(5 hunks)web/src/locales/ro.json
(5 hunks)web/src/locales/ru.json
(5 hunks)web/src/locales/sv.json
(5 hunks)web/src/locales/uk.json
(5 hunks)web/src/locales/zh.json
(6 hunks)
"jsonforms.oidc.accordion.authorizationRules.description": "Konfigurieren Sie, wer auf Ihren Server zugreifen kann", | ||
"jsonforms.oidc.accordion.authorizationRules.label": "Beispiele für den einfachen Modus", | ||
"jsonforms.oidc.accordion.authorizationRules.title": "Beispiele für den einfachen Modus", | ||
"jsonforms.oidc.accordion.basicConfiguration.description": "Essential provider settings", | ||
"jsonforms.oidc.accordion.basicConfiguration.label": "Basic Configuration", | ||
"jsonforms.oidc.accordion.basicConfiguration.title": "Basic Configuration", | ||
"jsonforms.oidc.accordion.buttonCustomization.description": "Customize the appearance of the login button", | ||
"jsonforms.oidc.accordion.buttonCustomization.label": "Button Customization", | ||
"jsonforms.oidc.accordion.buttonCustomization.title": "Button Customization", | ||
"jsonforms.oidc.buttons.description": "Customize the appearance of the login button", | ||
"jsonforms.oidc.accordion.basicConfiguration.description": "Wesentliche Anbietereinstellungen", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect German translation of “Authorization Rules”.
The English source is “Authorization Rules”, but the new label/title now read “Beispiele für den einfachen Modus”, which means “Examples for the simple mode” and misleads the UI. Please restore an accurate translation such as “Autorisierungsregeln”.
🤖 Prompt for AI Agents
In web/src/locales/de.json around lines 106 to 109, the keys
"jsonforms.oidc.accordion.authorizationRules.label" and
"jsonforms.oidc.accordion.authorizationRules.title" were mistranslated as
"Beispiele für den einfachen Modus"; change both values to an accurate German
translation like "Autorisierungsregeln" (leave the description key
"jsonforms.oidc.accordion.authorizationRules.description" as-is).
Summary by CodeRabbit