Skip to content

Conversation

elibosley
Copy link
Member

@elibosley elibosley commented Oct 14, 2025

Summary by CodeRabbit

  • New Features
    • Expanded and refined translations across the UI for Arabic, Bengali, Catalan, Czech, Danish, German, Spanish, French, Hindi, Croatian, Hungarian, Italian, Japanese, Korean, Latvian, Dutch, Norwegian, Polish, Portuguese, Romanian, Russian, Swedish, Ukrainian, and Chinese.
    • Updated labels, titles, and descriptions for API key management, OIDC/SSO configuration, buttons, and restrictions to native-language equivalents.
    • Improves readability and consistency in localized interfaces; no functional changes.

Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

Updated localization strings across multiple locale JSON files for API key, OIDC, and SSO UI sections. English texts were replaced with translations (e.g., titles, labels, descriptions) in numerous languages. No structural, logic, or control-flow changes; only content updates to existing keys.

Changes

Cohort / File(s) Summary
Locale translations update
web/src/locales/*.json (ar, bn, ca, cs, da, de, es, fr, hi, hr, hu, it, ja, ko, lv, nl, no, pl, pt, ro, ru, sv, uk, zh)
Replaced English UI strings with localized translations for API key, OIDC, and SSO titles, labels, and descriptions; no new/removed keys or code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paws—new words to show,
Across the fields where locales grow.
From API keys to SSO’s door,
Each tongue now sings a little more.
A hop, a skip, translations spread—
Carrots for all, well-localized bread! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “New Crowdin updates” clearly signals that the pull request brings in updated translation resources from Crowdin, which is the main change in the changeset. It is concise and directly references the translation platform used, tying it to the localization updates present across all locale files.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch l10n_main

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.64%. Comparing base (e9e271a) to head (76d2d19).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1750   +/-   ##
=======================================
  Coverage   52.64%   52.64%           
=======================================
  Files         866      866           
  Lines       49335    49335           
  Branches     4940     4940           
=======================================
  Hits        25972    25972           
  Misses      23290    23290           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1750/dynamix.unraid.net.plg

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (6)
web/src/locales/pt.json (1)

455-456: Untranslated string remains in Portuguese bundle

updateOs.update.acklowledgeThatYouHaveMadeA still shows the original English sentence, so users will see a mixed-language UI. Please translate it consistently with the rest of the file.

Aplicar esta correção:

-"updateOs.update.acklowledgeThatYouHaveMadeA": "Acknowledge that you have made a Flash Backup to enable this action",
+"updateOs.update.acklowledgeThatYouHaveMadeA": "Reconheça que você fez um backup do Flash para habilitar esta ação",
web/src/locales/bn.json (1)

52-563: Preserve placeholder identifiers in translations

Many formatted strings replaced placeholders like {filter}, {label}, {error}, {count}, {value} with Bengali text (e.g., {ফিল্টার}, {লেবেল}, {ত্রুটি}). The i18n formatter expects the original token names, so these changes will throw interpolation errors or render the raw braces. Revert each placeholder to the exact key used in the source.

Example fix:

-"connectSettings.filteringLogsFor": "\"{ফিল্টার}\" এর জন্য লগ ফিল্টার করা হচ্ছে",
+"connectSettings.filteringLogsFor": "\"{filter}\" এর জন্য লগ ফিল্টার করা হচ্ছে",
-"logs.singleViewer.errorDownloadingLogFile": "লগ ফাইল ডাউনলোড করতে সমস্যা: {ত্রুটি}",
+"logs.singleViewer.errorDownloadingLogFile": "লগ ফাইল ডাউনলোড করতে সমস্যা: {error}",
-"logs.viewer.formattedSize": "{মান} {একক}",
+"logs.viewer.formattedSize": "{value} {unit}",

Please apply the same correction wherever placeholders were renamed.

web/src/locales/hu.json (1)

423-429: Restore meaningful downgrade translations

Strings like “Berry Dance to {0}” and “Minden jogorvoslati ajánlat…” are garbled and no longer convey the downgrade instructions. Please revert them to accurate Hungarian equivalents so the downgrade flow remains understandable.

web/src/locales/zh.json (1)

297-297: Translate the remaining English label

“License key type” is still in English while the surrounding strings are localized. Please provide the Chinese translation to keep the UI consistent.

web/src/locales/hr.json (1)

57-57: Correct the downgrade title

“Nadogradite Unraid OS” means “Upgrade Unraid OS”, which is the opposite of the intended action. Please change it to a proper downgrade phrasing (e.g., “Ponižite Unraid OS” / “Vratite Unraid OS na stariju verziju”).

web/src/locales/fr.json (1)

318-318: Localize the remaining English sentence

“Requires the local unraid-api to be running successfully” is still English. Please translate it into French to keep the interface fully localized.

🧹 Nitpick comments (1)
web/src/locales/hi.json (1)

104-106: Pluralize the Hindi translation for “Advanced Endpoints”.

“Advanced Endpoints” is plural, but the current Hindi string “उन्नत एंडपॉइंट” is singular. Please change it to “उन्नत एंडपॉइंट्स” (or another plural form) to match the source.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9e271a and 76d2d19.

📒 Files selected for processing (24)
  • web/src/locales/ar.json (5 hunks)
  • web/src/locales/bn.json (5 hunks)
  • web/src/locales/ca.json (5 hunks)
  • web/src/locales/cs.json (5 hunks)
  • web/src/locales/da.json (5 hunks)
  • web/src/locales/de.json (6 hunks)
  • web/src/locales/es.json (6 hunks)
  • web/src/locales/fr.json (6 hunks)
  • web/src/locales/hi.json (5 hunks)
  • web/src/locales/hr.json (5 hunks)
  • web/src/locales/hu.json (5 hunks)
  • web/src/locales/it.json (5 hunks)
  • web/src/locales/ja.json (5 hunks)
  • web/src/locales/ko.json (5 hunks)
  • web/src/locales/lv.json (5 hunks)
  • web/src/locales/nl.json (6 hunks)
  • web/src/locales/no.json (5 hunks)
  • web/src/locales/pl.json (5 hunks)
  • web/src/locales/pt.json (5 hunks)
  • web/src/locales/ro.json (5 hunks)
  • web/src/locales/ru.json (5 hunks)
  • web/src/locales/sv.json (5 hunks)
  • web/src/locales/uk.json (5 hunks)
  • web/src/locales/zh.json (6 hunks)

Comment on lines +106 to +109
"jsonforms.oidc.accordion.authorizationRules.description": "Konfigurieren Sie, wer auf Ihren Server zugreifen kann",
"jsonforms.oidc.accordion.authorizationRules.label": "Beispiele für den einfachen Modus",
"jsonforms.oidc.accordion.authorizationRules.title": "Beispiele für den einfachen Modus",
"jsonforms.oidc.accordion.basicConfiguration.description": "Essential provider settings",
"jsonforms.oidc.accordion.basicConfiguration.label": "Basic Configuration",
"jsonforms.oidc.accordion.basicConfiguration.title": "Basic Configuration",
"jsonforms.oidc.accordion.buttonCustomization.description": "Customize the appearance of the login button",
"jsonforms.oidc.accordion.buttonCustomization.label": "Button Customization",
"jsonforms.oidc.accordion.buttonCustomization.title": "Button Customization",
"jsonforms.oidc.buttons.description": "Customize the appearance of the login button",
"jsonforms.oidc.accordion.basicConfiguration.description": "Wesentliche Anbietereinstellungen",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Fix incorrect German translation of “Authorization Rules”.

The English source is “Authorization Rules”, but the new label/title now read “Beispiele für den einfachen Modus”, which means “Examples for the simple mode” and misleads the UI. Please restore an accurate translation such as “Autorisierungsregeln”.

🤖 Prompt for AI Agents
In web/src/locales/de.json around lines 106 to 109, the keys
"jsonforms.oidc.accordion.authorizationRules.label" and
"jsonforms.oidc.accordion.authorizationRules.title" were mistranslated as
"Beispiele für den einfachen Modus"; change both values to an accurate German
translation like "Autorisierungsregeln" (leave the description key
"jsonforms.oidc.accordion.authorizationRules.description" as-is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant