Rebuild #23
Merged
Rebuild #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @Elliot-Alexander ! Looking at this PR today! 😁 |
Deploying with
|
| Latest commit: |
a058285
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://84811f97.vaul-vue.pages.dev |
| Branch Preview URL: | https://rebuild.vaul-vue.pages.dev |
refactor: use antfu/eslint
|
@Elliot-Alexander I've made 'some' changes 😂 and seems like all the tests are passing now. (temporary hide webkit as there's some weird behavior with 1 of the test). Let me know if the above fixes the
you mentioned earlier. |
|
@Elliot-Alexander Nicely done on making it closer to Vue DX. I will merge this in for now ya! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructured a huge chunk of the controls and Drawer Root to make things more readable and more 'Vue' flavoured.
Currently running into a big issue with the controlled (and the types of controlled) vs uncontrolled. The test case to compare between this and the original package is the
controlledtest in the playwright tests through playground.Would definitely be open to any help on this one.