Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: primarycommand text theme changing #1342

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Feb 12, 2025

GitHub Issue (If applicable): closes #1341

PR Type

What kind of change does this PR introduce?

  • Bugfix

The following code was tested:

<utu:NavigationBar.PrimaryCommands>
	<AppBarButton Label="More" Style="{StaticResource DefaultAppBarButtonStyle}" />
	<AppBarButton Content="More" Style="{StaticResource DefaultAppBarButtonStyle}" />
</utu:NavigationBar.PrimaryCommands>

What is the current behavior?

See linked issue for video. PrimaryCommands weren't being invalidated when they only contained text (label or content).

What is the new behavior?

Setting the ActionView that the PrimaryCommand displays allows them to be invalidated on a theme change.

Android:

NavBarThemeChanging.mp4

iOS:

NavBarThemeChangingiOS.mp4

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@rajamatt rajamatt self-assigned this Feb 12, 2025
@rajamatt rajamatt changed the title fix: android primarycommand text theme changing fix: primarycommand text theme changing Feb 12, 2025
@unodevops
Copy link

⚠️⚠️ The build 156217 has failed on Uno Toolkit - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android/iOS][NavigationBar] PrimaryCommand with text fails to update when switching themes
2 participants