fix: primarycommand text theme changing #1342
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #1341
PR Type
What kind of change does this PR introduce?
The following code was tested:
What is the current behavior?
See linked issue for video. PrimaryCommands weren't being invalidated when they only contained text (label or content).
What is the new behavior?
Setting the
ActionView
that the PrimaryCommand displays allows them to be invalidated on a theme change.Android:
NavBarThemeChanging.mp4
iOS:
NavBarThemeChangingiOS.mp4
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):