UL-1006: Add tutorial automation test #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umermansoor
reviewed
Nov 21, 2021
| @@ -52,23 +52,23 @@ public void register() { | |||
|
|
|||
| public void otp() { | |||
| Browser.fluentWait((WebDriver d) -> d.findElement(By.cssSelector("input[type=tel]"))).sendKeys("455148"); | |||
| /* Verify otp right away after code is entered | |||
There was a problem hiding this comment.
why is this commented out?
There was a problem hiding this comment.
because after code is entered, it verifies right away, there is no button to click.
umermansoor
reviewed
Nov 21, 2021
|
|
||
| @Test | ||
| @Order(7) | ||
| @Order(80) |
There was a problem hiding this comment.
so we can add more tests in without changing everything all the order numbers.
umermansoor
reviewed
Nov 21, 2021
| evaluator.close(); | ||
|
|
||
| // Make sure event is received | ||
| Browser.sleep(1); |
There was a problem hiding this comment.
perhaps sleep for more like 5 seconds?
There was a problem hiding this comment.
we call close(), it flushes events, so 1 second is probably enough, I will make it 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.