Skip to content

fix: webpack / rspack load virtual module with '/' prefix on windows platform #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: webpack / rspack load virtual module with '/' prefix on windows platform #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0675ee6
feat(test): load virtural module with prefix
tmg0 Sep 23, 2024
f4b6556
fix: load virtual module with prefix error
tmg0 Sep 23, 2024
dccf8e8
chore: use latest lock file
tmg0 Sep 26, 2024
9a3f8ef
Merge branch 'unjs:main' into main
tmg0 Sep 26, 2024
077d35c
feat: update fixtures in tests
tmg0 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/rspack/loaders/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,18 @@ export default async function load(this: LoaderContext, source: string, map: any
id = decodeVirtualModuleId(id, plugin)

const context = createContext(this)

id = normalizeAbsolutePath(id)
if (id.startsWith('\\'))
id = id.replace(/\\/g, '/')

const res = await plugin.load.call(
Object.assign(
{},
this._compilation && createBuildContext(this._compiler, this._compilation, this),
context,
),
normalizeAbsolutePath(id),
id,
)

if (res == null)
Expand Down
7 changes: 6 additions & 1 deletion src/webpack/loaders/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ export default async function load(this: LoaderContext<{ unpluginName: string }>
id = decodeURIComponent(id.slice(plugin.__virtualModulePrefix.length))

const context = createContext(this)

id = normalizeAbsolutePath(id)
if (id.startsWith('\\'))
id = id.replace(/\\/g, '/')

const res = await plugin.load.call(
Object.assign({}, createBuildContext({
addWatchFile: (file) => {
Expand All @@ -25,7 +30,7 @@ export default async function load(this: LoaderContext<{ unpluginName: string }>
return this.getDependencies()
},
}, this._compiler!, this._compilation, this), context),
normalizeAbsolutePath(id),
id,
)

if (res == null)
Expand Down