Skip to content

feat: use fix-dts-default-cjs-exports to transform cjs types #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Feb 24, 2025

This PR includes:

I want to do some local test before releasing...

resolves #474
supersedes #475

@userquin
Copy link
Contributor Author

Uhmm, the library using Rollup 4.34.8 and here 4.34.6, should we also update Rollup here?

@userquin
Copy link
Contributor Author

userquin commented Feb 24, 2025

Looks like it is working correctly, check this PR from the original issue playground: userquin/unbuild-cts-issue#1

@pi0 pi0 changed the title fix: default CJS exports feat: use fix-dts-default-cjs-exports to transform cjs types Feb 26, 2025
@userquin
Copy link
Contributor Author

@pi0 conflicts resolved 🙏

@userquin
Copy link
Contributor Author

Dont merge yet, I just release 1.0.0

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pi0 pi0 merged commit 3edb456 into unjs:main Feb 26, 2025
2 checks passed
@userquin userquin deleted the fix-default-cjs-exports branch February 26, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dts for node10 and node16 cjs still wrong with type module
2 participants