-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hashAsync
and sha256*Async
utils
#41
Draft
pi0
wants to merge
10
commits into
main
Choose a base branch
from
feat/async-hash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 80.53% 80.81% +0.28%
==========================================
Files 8 8
Lines 981 1006 +25
Branches 126 132 +6
==========================================
+ Hits 790 813 +23
- Misses 191 193 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pi0
changed the title
feat:
feat: Sep 15, 2024
asyncHash
with native sha256 digest and fallbackhashAsync
with native sha256 digest and fallback
(update: renaming to |
pi0
changed the title
feat:
feat: Sep 15, 2024
hashAsync
with native sha256 digest and fallbackhashAsync
and sha256*Async
utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25
Add a new
asyncHash
to leverage the native platform hashing mechanism usingSubtleCrypto digest()
. When not available, ohash falls back to js implementation.Benchmarks:
local run
node benchmark/hash.mjs
(with the exception of a few items, it is not faster, than investigating..)