feat: support BROWSER environment variable
#210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #154
Note
The current implementation only covers half the features of
open, and lacks automatic platform detection for the browser.This might not provide a good DX (users have to specify
BROWSER="Google Chrome"on macOS andBROWSER=chromein Windows). I'm hesitant to port all the implementations due to the large amount of code duplication.Instead, should we consider simply using the
openpackage? We could inline it during the build to avoid installing an extra package if that's a concern. WDYT? 🤔