Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global publish via first subscribed peer #103

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

sandros94
Copy link
Contributor

@sandros94 sandros94 commented Jan 10, 2025

Resolves #86

Either if I keep topics private or make it accessible, it works on all adapters except for Bun and uWebSockets for some reasons. Only for those two the tests timeout and I can't understand why, need help on this

@pi0 pi0 marked this pull request as ready for review February 10, 2025 19:25
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9a8d499). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/adapters/uws.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage        ?   76.27%           
=======================================
  Files           ?        9           
  Lines           ?      725           
  Branches        ?      146           
=======================================
  Hits            ?      553           
  Misses          ?      170           
  Partials        ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 merged commit abe67f8 into unjs:main Feb 10, 2025
4 checks passed
@pi0
Copy link
Member

pi0 commented Feb 10, 2025

Thank you!

@sandros94 sandros94 deleted the fix-global-publish branch February 11, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish to first subscribed peer
2 participants