Definition rendering fixes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
changed the title
ChrisPenner
force-pushed
the
cp/fix-hq-docs
branch
from
8bf14a1 to
6f4d5b4
Compare
hojberg
approved these changes
Feb 13, 2025
| @@ -52,7 +52,11 @@ | |||
| }, | |||
| { | |||
| "annotation": null, | |||
| "segment": " " | |||
| "segment": "\n" | |||
There was a problem hiding this comment.
Yup; I added a manual break in ability pretty-printing;
Previously:
ability Blah where foo : Nat -> Nat
Now:
ability Blah where
foo : Nat -> Nat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Share wouldn't find docs for definitions in Lib if they were linked via a hash, this fixes that.
Also, use suffixified names for self-references in types and abilities
Also, render abilities on two lines, always.
Implementation notes
We first search for the name via the hash, then we re-scope the doc search to wherever the name was found, even if that's in a lib.
Also updates the ucm version used in CI and updates transcripts to match.
Test coverage