Allow computing arbitrary namespace diffs #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than diff from the empty branch
ChrisPenner
force-pushed
the
cp/arbitrary-namespace-diffs
branch
from
e97b6c8 to
173b852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows computing diffs between arbitrary namespaces or releases with in a project.
You can access this feature via:
/users/<user>/projects/<slug>/diff/namespaces?old=<old>&new=<new>Where
oldandnewcan be any branch, contributor branch, or release ref.This uses the same code as the contribution diff, so on initial fetch it will simply respond with the "computing" status and will kick off a background job.
We should be able to get this to realtime for most cases soon 🤞🏼
Implementation notes
Switches the existing namespace diffing to use the new causal-diff-queue mechanism
Test coverage
Added new transcripts