Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.plist: Add public.unicodeVariationSequences #176

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

moyogo
Copy link
Collaborator

@moyogo moyogo commented Apr 11, 2021

This adds a standard lib key public.unicodeVariationSequences for Unicode Variation Sequences. The structure follows what was suggested in #77 (comment) and #79 (comment) (and the next comment).

There's an issue for UVS support in UFO4, #79, but support is needed in UFO3.

Copy link
Contributor

@benkiel benkiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to help clarify (possibly)

This key is a dictionary for Unicode Variation Sequences. Keys are *Variation Selector* code points as a hexadecimal numbers and values are dictionaries. These dictionaries contain code points as hexidecimal numbers as keys and glyph names as values. This data can be used to generate the [OpenType cmap subtable format 14] for Unicode [Variation Sequences].

This data is optional.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to note that this format may be deprecated/changed in UFO4 based on whatever is decided to do about unicodes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should have any note about UFO4 which is still very much undefined, here or anywhere else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Ok.

@benkiel benkiel merged commit 1590b9b into unified-font-object:gh-pages Apr 12, 2021
@moyogo
Copy link
Collaborator Author

moyogo commented Apr 12, 2021

Thank you Ben!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants