Fix contradiction in markup resolution #1084
Open
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this stated that markup resolution MUST always succeed. However, resolution of `u:` options can fail, so that wasn't true.
|
I noticed this when looking at this test: https://github.com/unicode-org/message-format-wg/blob/main/test/tests/u-options.json#L37 |
eemeli
requested changes
Jun 28, 2025
There was a problem hiding this comment.
While the resolution of individual options can fail, this still holds:
message-format-wg/spec/formatting.md
Lines 410 to 412 in 9448040
In other words, overall resolution of markup will always succeed.
If there is some language in u: options or elsewhere that implies something different, that needs to be fixed rather than changing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this stated that markup resolution MUST always succeed. However, resolution of
u:options can fail, so that wasn't true.