Make expErrors use an array (and only an array) #1076
Conversation
mihnita
requested review from
eemeli,
mradbourne and
aphillips
and removed request for
eemeli
| @@ -5,7 +5,7 @@ | |||
| "defaultTestProperties": { | |||
| "bidiIsolation": "none", | |||
| "locale": "en-US", | |||
| "expErrors": false | |||
| "expErrors": [] | |||
There was a problem hiding this comment.
In fallback.md you left out expErrors. Here you supply an empty array. I think we should probably omit this one?
There was a problem hiding this comment.
@aphillips It's required in this file otherwise some tests would be left without an expectation (e.g. lines 44-55). This would also be the case in time.json.
As Eemeli mentioned in his review comment, I think we need to keep the expErrors in fallback.md.
There was a problem hiding this comment.
I think we are talking about fallback.json, not fallback.md?
I updated fallback.json and added errors for each individual case, instead of doing it in defaultTestProperties
There was a problem hiding this comment.
For date.json, datetime.json and time.json I added "expErrors": [] to defaultTestProperties because the schema says that entries are required to have one of exp, expParts or expErrors
In these 3 files we had tests with src only.
So I had to add a expErrors (not enough info for exp, expParts, exact date/time formatting not part of the spec)
| @@ -5,7 +5,7 @@ | |||
| "defaultTestProperties": { | |||
| "bidiIsolation": "none", | |||
| "locale": "en-US", | |||
| "expErrors": false | |||
| "expErrors": [] | |||
aphillips
changed the title
Co-authored-by: Eemeli Aro <[email protected]>
Co-authored-by: Eemeli Aro <[email protected]>
Co-authored-by: Eemeli Aro <[email protected]>
Co-authored-by: Eemeli Aro <[email protected]>
Co-authored-by: Eemeli Aro <[email protected]>
Co-authored-by: Eemeli Aro <[email protected]>
|
need to change bad operand to bad option (2025-06-16) |
|
In 2025-06-30 call, we agreed to merge this once @eemeli has reviewed positively. Nudging him gently with this comment. |
| }, | ||
| "tests": [ | ||
| { | ||
| "description": "function with unquoted literal operand", | ||
| "src": "{42 :test:function fails=format}", | ||
| "exp": "{|42|}", | ||
| "expParts": [{ "type": "fallback", "source": "|42|" }] | ||
| "expParts": [{ "type": "fallback", "source": "|42|" }], | ||
| "expErrors": [{ "type": "bad-operand" }] |
There was a problem hiding this comment.
| "expErrors": [{ "type": "bad-operand" }] | |
| "expErrors": [{ "type": "bad-option" }] |
Fixes issue #993