Require public fields for Bake derive

components/pattern/tests/derive_test.rs

@@ -19,7 +19,7 @@ struct DeriveTest_SinglePlaceholderPattern_Cow<'data> {
         borrow,
         deserialize_with = "icu_pattern::deserialize_borrowed_cow::<SinglePlaceholder, _>"
     )]
-    data: Cow<'data, Pattern<SinglePlaceholder>>,
+    pub data: Cow<'data, Pattern<SinglePlaceholder>>,
 }
 
 #[test]

tutorials/data-provider-runtime.md

@@ -282,7 +282,7 @@ icu_provider::data_marker!(CustomV1, Custom<'static>);
 #[derive(Debug, PartialEq, serde::Deserialize, serde::Serialize, databake::Bake, yoke::Yokeable, zerofrom::ZeroFrom)]
 #[databake(path = crate)]
 pub struct Custom<'data> {
-    message: Cow<'data, str>,
+    pub message: Cow<'data, str>,
 };
 
 icu_provider::data_struct!(Custom<'_>);

utils/databake/derive/src/lib.rs

@@ -11,7 +11,7 @@ use syn::{
     parse::{Parse, ParseStream},
     parse_macro_input,
     punctuated::Punctuated,
-    DeriveInput, Ident, Path, PathSegment, Token,
+    Data, DeriveInput, Ident, Path, PathSegment, Token, Visibility,
 };
 use synstructure::{AddBounds, Structure};
 
@@ -68,7 +68,12 @@ fn bake_derive_impl(input: &DeriveInput) -> TokenStream2 {
             quote! { let #ident =  #ident.bake(env); }
         });
 
-        let constructor = vi.construct(|_, i| {
+        let constructor = vi.construct(|f, i| {
+            assert!(
+                f.vis == syn::parse_str::<Visibility>("pub").unwrap()
+                    || matches!(input.data, Data::Enum(_)),
+                "deriving Bake requires public fields"
+            );
             let ident = &vi.bindings()[i].binding;
             quote! { # #ident }
         });

utils/databake/derive/tests/derive.rs

@@ -9,7 +9,7 @@ use databake::*;
 #[derive(Bake)]
 #[databake(path = test)]
 pub struct IntExample {
-    x: u8,
+    pub x: u8,
 }
 
 #[test]
@@ -20,8 +20,8 @@ fn test_int_example() {
 #[derive(Bake)]
 #[databake(path = test)]
 pub struct GenericsExample<T> {
-    x: u32,
-    y: T,
+    pub x: u32,
+    pub y: T,
 }
 
 #[test]
@@ -40,10 +40,10 @@ fn test_generics_example() {
 #[derive(Bake)]
 #[databake(path = test)]
 pub struct CowExample<'a> {
-    x: u8,
-    y: &'a str,
-    z: alloc::borrow::Cow<'a, str>,
-    w: alloc::borrow::Cow<'a, [u8]>,
+    pub x: u8,
+    pub y: &'a str,
+    pub z: alloc::borrow::Cow<'a, str>,
+    pub w: alloc::borrow::Cow<'a, [u8]>,
 }
 
 #[test]

utils/databake/src/converter.rs

@@ -24,8 +24,8 @@ use quote::quote;
 /// #[derive(Bake)]
 /// #[databake(path = my_crate)]
 /// struct Data {
-///     number: usize,
-///     string: AsStaticStr<String>, // can be written as StringAsStaticStr
+///     pub number: usize,
+///     pub string: AsStaticStr<String>, // can be written as StringAsStaticStr
 /// }
 ///
 /// let data = Data {
@@ -139,7 +139,7 @@ pub type StringAsStaticStr = AsStaticStr<String>;
 /// #[derive(Bake, Default)]
 /// #[databake(path = my_crate)]
 /// struct Data {
-///     numbers: IteratorAsRefSlice<Vec<usize>, usize>, // can be written as `VecAsRefSlice<usize>`
+///     pub numbers: IteratorAsRefSlice<Vec<usize>, usize>, // can be written as `VecAsRefSlice<usize>`
 /// }
 ///
 /// let mut data = Data::default();

utils/databake/src/lib.rs

@@ -30,14 +30,14 @@
 //! #[derive(Bake)]
 //! #[databake(path = my_crate)]
 //! struct MyStruct {
-//!     number: u32,
-//!     string: &'static str,
-//!     slice: &'static [bool],
+//!     pub number: u32,
+//!     pub string: &'static str,
+//!     pub slice: &'static [bool],
 //! }
 //!
 //! #[derive(Bake)]
 //! #[databake(path = my_crate)]
-//! struct AnotherOne(MyStruct, char);
+//! struct AnotherOne(pub MyStruct, pub char);
 //! ```
 //!
 //! # Testing
@@ -48,13 +48,13 @@
 //! # #[derive(Bake)]
 //! # #[databake(path = my_crate)]
 //! # struct MyStruct {
-//! #   number: u32,
-//! #   string: &'static str,
-//! #   slice: &'static [bool],
+//! #   pub number: u32,
+//! #   pub string: &'static str,
+//! #   pub slice: &'static [bool],
 //! # }
 //! # #[derive(Bake)]
 //! # #[databake(path = my_crate)]
-//! # struct AnotherOne(MyStruct, char);
+//! # struct AnotherOne(pub MyStruct, pub char);
 //! # fn main() {
 //! test_bake!(
 //!     AnotherOne,

utils/zerotrie/tests/derive_test.rs

@@ -18,7 +18,7 @@ use zerovec::ZeroVec;
 #[cfg_attr(feature = "databake", databake(path = crate))]
 struct DeriveTest_ZeroTrie_ZeroVec<'data> {
     #[cfg_attr(feature = "serde", serde(borrow))]
-    _data: ZeroTrie<ZeroVec<'data, u8>>,
+    pub _data: ZeroTrie<ZeroVec<'data, u8>>,
 }
 
 #[test]
@@ -44,7 +44,7 @@ fn bake_ZeroTrie_ZeroVec() {
 #[cfg_attr(feature = "databake", databake(path = crate))]
 struct DeriveTest_ZeroTrieSimpleAscii_ZeroVec<'data> {
     #[cfg_attr(feature = "serde", serde(borrow))]
-    _data: ZeroTrieSimpleAscii<ZeroVec<'data, u8>>,
+    pub _data: ZeroTrieSimpleAscii<ZeroVec<'data, u8>>,
 }
 
 #[test]
@@ -69,7 +69,7 @@ fn bake_ZeroTrieSimpleAscii_ZeroVec() {
 #[cfg_attr(feature = "databake", databake(path = crate))]
 struct DeriveTest_ZeroAsciiIgnoreCaseTrie_ZeroVec<'data> {
     #[cfg_attr(feature = "serde", serde(borrow))]
-    _data: ZeroAsciiIgnoreCaseTrie<ZeroVec<'data, u8>>,
+    pub _data: ZeroAsciiIgnoreCaseTrie<ZeroVec<'data, u8>>,
 }
 
 #[test]
@@ -94,7 +94,7 @@ fn bake_ZeroAsciiIgnoreCaseTrie_ZeroVec() {
 #[cfg_attr(feature = "databake", databake(path = crate))]
 struct DeriveTest_ZeroTriePerfectHash_ZeroVec<'data> {
     #[cfg_attr(feature = "serde", serde(borrow))]
-    _data: ZeroTriePerfectHash<ZeroVec<'data, u8>>,
+    pub _data: ZeroTriePerfectHash<ZeroVec<'data, u8>>,
 }
 
 #[test]
@@ -119,7 +119,7 @@ fn bake_ZeroTriePerfectHash_ZeroVec() {
 #[cfg_attr(feature = "databake", databake(path = crate))]
 struct DeriveTest_ZeroTrieExtendedCapacity_ZeroVec<'data> {
     #[cfg_attr(feature = "serde", serde(borrow))]
-    _data: ZeroTrieExtendedCapacity<ZeroVec<'data, u8>>,
+    pub _data: ZeroTrieExtendedCapacity<ZeroVec<'data, u8>>,
 }
 
 #[test]

utils/zerovec/src/yoke_impls.rs

@@ -314,7 +314,7 @@ mod test {
     #[cfg_attr(feature = "databake", databake(path = zerovec::yoke_impls::test))]
     struct DeriveTest_ZeroVec<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: ZeroVec<'data, u16>,
+        pub _data: ZeroVec<'data, u16>,
     }
 
     #[test]
@@ -334,7 +334,7 @@ mod test {
     #[cfg_attr(feature = "databake", databake(path = zerovec::yoke_impls::test))]
     struct DeriveTest_ZeroSlice<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: &'data ZeroSlice<u16>,
+        pub _data: &'data ZeroSlice<u16>,
     }
 
     #[test]
@@ -354,7 +354,7 @@ mod test {
     #[cfg_attr(feature = "databake", databake(path = zerovec::yoke_impls::test))]
     struct DeriveTest_VarZeroVec<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: VarZeroVec<'data, str>,
+        pub _data: VarZeroVec<'data, str>,
     }
 
     #[test]
@@ -374,7 +374,7 @@ mod test {
     #[cfg_attr(feature = "databake", databake(path = zerovec::yoke_impls::test))]
     struct DeriveTest_VarZeroSlice<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: &'data VarZeroSlice<str>,
+        pub _data: &'data VarZeroSlice<str>,
     }
 
     #[test]
@@ -395,7 +395,7 @@ mod test {
     #[yoke(prove_covariance_manually)]
     struct DeriveTest_ZeroMap<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: ZeroMap<'data, [u8], str>,
+        pub _data: ZeroMap<'data, [u8], str>,
     }
 
     #[test]
@@ -422,7 +422,7 @@ mod test {
     #[yoke(prove_covariance_manually)]
     struct DeriveTest_ZeroMapBorrowed<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: ZeroMapBorrowed<'data, [u8], str>,
+        pub _data: ZeroMapBorrowed<'data, [u8], str>,
     }
 
     #[test]
@@ -449,7 +449,7 @@ mod test {
     #[yoke(prove_covariance_manually)]
     struct DeriveTest_ZeroMapWithULE<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: ZeroMap<'data, ZeroSlice<u32>, str>,
+        pub _data: ZeroMap<'data, ZeroSlice<u32>, str>,
     }
 
     #[test]
@@ -476,7 +476,7 @@ mod test {
     #[yoke(prove_covariance_manually)]
     struct DeriveTest_ZeroMap2d<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: ZeroMap2d<'data, u16, u16, str>,
+        pub _data: ZeroMap2d<'data, u16, u16, str>,
     }
 
     #[test]
@@ -505,7 +505,7 @@ mod test {
     #[yoke(prove_covariance_manually)]
     struct DeriveTest_ZeroMap2dBorrowed<'data> {
         #[cfg_attr(feature = "serde", serde(borrow))]
-        _data: ZeroMap2dBorrowed<'data, u16, u16, str>,
+        pub _data: ZeroMap2dBorrowed<'data, u16, u16, str>,
     }
 
     #[test]