-
-
Notifications
You must be signed in to change notification settings - Fork 838
Make ICU ptest output compatible with Automake format #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
We don't want to unconditionally change the test suite output after 25+ years. What is "ptest"?
Please follow the instructions from https://icu.unicode.org/bugs |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
@markusicu You're right — changing the default test output would not be ideal after so many years. Regarding your question:
Thanks for the clarification and the link! I’ve followed the instructions on https://icu.unicode.org/bugs and successfully logged into the ICU JIRA site. Thanks again for the helpful comments! |
Update ICU ptest output so that each test prints in the Automake "simple test" format required by Yocto[1]: result: testname Where `result` is one of PASS, FAIL, or SKIP. [1] https://wiki.yoctoproject.org/wiki/Ptest Signed-off-by: Jiaying Song <[email protected]>
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
|
||
| # Enable Automake-compatible ptest output format (for Yocto/OpenEmbedded) | ||
| AC_ARG_ENABLE([ptest-automake-format], | ||
| AS_HELP_STRING([--enable-ptest-automake-format], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just say 'test'? ptest is a yocto thing, it doesn't mean anything to others. But I'd be interested in possibly using this in Gentoo. It's really just that the testsuite format will be automake format (TAP) now.
The rationale is that it's for Yocto, but that's more for the commit message, not the option name or help description IMO.
Update ICU ptest output so that each test prints in the Automake "simple test" format required by Yocto[1]:
result: testname
Where
resultis one of PASS, FAIL, or SKIP.[1] https://wiki.yoctoproject.org/wiki/Ptest
Note: I do not currently have permissions to create an ICU Jira issue. I am submitting this patch to discuss the change and its approach with the ICU team. Once the PR is reviewed, a Jira issue can be created and associated if required.