fix(docker): handle cgroup v2 'max' in memory guard (#2123) - #2196
Open
Battleplus wants to merge 1 commit into
Open
fix(docker): handle cgroup v2 'max' in memory guard (#2123)#2196Battleplus wants to merge 1 commit into
Battleplus wants to merge 1 commit into
Conversation
On cgroup v2 with no container memory limit, memory.max contains the
string "max". int("max") raised ValueError, the bare except caught it,
and the function returned host memory percentage instead of container's.
Parse limit as string first, handle "max" explicitly, then fall back to
int conversion for numeric values.
Closes unclecode#2123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2123 — On cgroup v2 with no container memory limit, memory.max contains the string "max". int("max") raised ValueError, the bare except caught it, and the function returned host memory percentage instead of container's.
Fix
Parse limit as string first, handle "max" explicitly (fall back to host total), then convert to int for numeric values.
Files changed