Skip to content

fix(api): return 408 for wait_for selector timeout in /crawl #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Battleplus wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix(api): return 408 for wait_for selector timeout in /crawl #2186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions deploy/docker/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,10 @@ async def handle_crawl_request(
# Per-crawl wall-clock deadline exceeded.
raise HTTPException(status_code=504, detail="Crawl exceeded the time limit")

except TimeoutError as e:
# wait_for selector / JS condition timed out — client error, not server.
raise HTTPException(status_code=408, detail=str(e))

except HTTPException:
# Deliberate status (e.g. 400 SSRF "URL blocked") must pass through
# rather than be genericized to 500 by the handler below.
Expand Down