fix: update docker-compose.yml for Compose v5 compatibility - #2177
Closed
Battleplus wants to merge 1 commit into
Closed
fix: update docker-compose.yml for Compose v5 compatibility#2177Battleplus wants to merge 1 commit into
Battleplus wants to merge 1 commit into
Conversation
- Remove obsolete 'version: 3.8' attribute - Move pids_limit from top level to deploy.resources.limits.pids - This fixes the 'can't set distinct values on pids_limit' error in Compose v5 Fixes unclecode#2091 Signed-off-by: Battleplus <3559424769@qq.com>
Author
|
Closing as superseded by #2094, already merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
version: '3.8'attributepids_limitfrom top level todeploy.resources.limits.pidsWhy
Fixes #2091 - docker-compose.yml is rejected by Compose v5 with 'can't set distinct values on pids_limit'.
Changes
version: '3.8'(obsolete, causes warnings)pids_limit: 512todeploy.resources.limits.pids: 512(compose-spec-compliant)Testing
docker compose configFixes #2091