Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove TOML config and related changes #7

Merged
merged 11 commits into from
Jan 24, 2025
Merged

Conversation

mmalenic
Copy link
Member

Closes umccr/htsget-rs#294 and umccr/htsget-rs#295.

I figured this would be a good spot to wrap up this PR.

Changes

  • Simplifies settings logic by removing TOML config files.
    • Boolean parameters like lookupHostedZone, copyExampleKeys, copyTestData, public are simplified. copyTestData now copies both test files and keys. lookupHostedZone is resolved based on the whether a hostedZone parameter is passed in, and public is determined based on the jwt
    • Features automatically resolve, with the option to specify cargoLambdaFlags manually.
  • Locations can now be configured using the simple location syntax. Advanced options can be specified using a environmentOverride parameter, whereas CORS and service-info are configured using separate properties.
    • Locations are automatically derived if using copyTestData.
  • Other minor fixes related to deployment logic and resolvers.
  • Added eslint and typedoc for documentation table generation.
  • Removed docker as it's part of htsget-rs.
  • Reworded documentation and deployment instructions.

@mmalenic mmalenic self-assigned this Jan 23, 2025
@mmalenic mmalenic added the enhancement New feature or request label Jan 23, 2025
@mmalenic mmalenic requested a review from brainstorm January 23, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ideally the user should be able to use typescript props to configure htsget-rs, rather than a TOML file.
1 participant