feat: allow specifying git reference when fetching htsget-rs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainstorm
approved these changes
Jan 7, 2025
bin/settings.ts
Outdated
| @@ -22,5 +22,5 @@ export const SETTINGS: HtsgetStatelessSettings & HtsgetStatefulSettings = { | |||
| jwtAudience: [""], // Should match your cognito client id, i.e: 3jgmc7kqaaf8mqbv2sgmujslrp | |||
| }, | |||
| // Enable additional features for compiling htsget-rs. `s3-storage` is always enabled. | |||
| features: ["experimental"], // i.e: Enables Crypt4Gh+htsget functionality | |||
| features: ["experimental", "s3-storage"], // i.e: Enables Crypt4Gh+htsget functionality | |||
There was a problem hiding this comment.
Shouldn't this flag be aws instead of s3-storage?
There was a problem hiding this comment.
Yes! Well.. it depends on the version of htsget-rs. I was planning to pin it to a released version until the new release which introduces the "aws" flag. But it can be "aws" here anyway as it's just an example config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes