-
Notifications
You must be signed in to change notification settings - Fork 811
Document for creating custom segment parameter #7462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document for creating custom segment parameter #7462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dtng95 I've left some comments/suggestions below - mainly to keep the linter happy, but also updated the manifest example.
It's probably worth adding a note too that this example depends on the Engage Backoffice NPM package, which hasn't been released yet.
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
Thanks for the PR, @dtng95. We will review it asap. |
Hey @dtng95 👋, Could you add the new article to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @dtng95 🙌 The PR looks great 💪
I have added several suggestions to remove “we,” fix vale errors and warnings, format technical terms, and align with the style guide. Let me know if anything is unclear.
Also, as mentioned above, kindly add an entry for the implement-custom-segment-parameters.md
article in the SUMMARY.md
file
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
...and-editors/personalization/extending-personalization/implement-custom-segment-parameters.md
Outdated
Show resolved
Hide resolved
- Update the doc based on docs team's comments - Move the new doc to an existing doc
Hi @eshanrnh , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the suggestions, @dtng95 🙌
The images are not showing in the Preview. Can you double-check the image paths since the article has been changed?
16/umbraco-engage/developers/personalization/implement-your-own-segment-parameters.md
Outdated
Show resolved
Hide resolved
…n-segment-parameters.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempt to fix images :)
16/umbraco-engage/developers/personalization/implement-your-own-segment-parameters.md
Outdated
Show resolved
Hide resolved
16/umbraco-engage/developers/personalization/implement-your-own-segment-parameters.md
Outdated
Show resolved
Hide resolved
16/umbraco-engage/developers/personalization/implement-your-own-segment-parameters.md
Outdated
Show resolved
Hide resolved
…n-segment-parameters.md
…n-segment-parameters.md
…n-segment-parameters.md
Thanks @eshanrnh for the update. Was about to push another update to fix the image, but you've already updated it. It looks good! |
📋 Description
📎 Related Issues (if applicable)
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
Engage V16
Deadline (if relevant)
📚 Helpful Resources