fix(uui-color-picker): sets preview color of empty value to transparent #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR restores transparent preview for empty color values and refines slider precision behavior.
- Ensures empty color picker values render as transparent rather than defaulting to black
- Adds
precisionto H, S, L sliders and updates template bindings to useifDefined - Explicitly annotates the
valueproperty type on the slider element
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/uui-color-slider/lib/uui-color-slider.story.ts | Added precision settings for sliders and updated bindings to use ifDefined for color/precision |
| packages/uui-color-slider/lib/uui-color-slider.element.ts | Specified { type: Number } for the value property |
| packages/uui-color-picker/lib/uui-color-picker.story.ts | Adjusted story value args to demonstrate transparent preview for empty states |
| packages/uui-color-picker/lib/uui-color-picker.element.ts | Introduced previewColor variable to render transparent background when value is empty |
Comments suppressed due to low confidence (2)
packages/uui-color-slider/lib/uui-color-slider.story.ts:198
- The
ifDefineddirective is used here but there's no import for it; please importifDefinedfrom 'lit-html/directives/if-defined.js' (or the appropriate package) to prevent runtime errors.
color=${ifDefined(
packages/uui-color-picker/lib/uui-color-picker.story.ts:95
- The Opacity story now sets
valuetoswatchesTransparent[8]instead ofundefined, so it no longer shows the empty state; consider reverting toundefinedto demonstrate the transparent preview as intended.
value: swatchesTransparent[8],
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1151.westeurope.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the UUI Color Picker component, sets the preview colour of an empty value to transparent.
In PR #1061, the change set the
alphato100for undefined values, this meant that all empty values would now appear as black (#000000), but the value would remain as empty.Prior to this change, the initial preview colour for empty values was transparent. This PR updates the preview colour accordingly.
Types of changes
How to test?
In the storybook for the Color Picker component, view the Empty story, notice that the button has a transparent background colour.