fix(uui-color-slider): sets max = 360
for hue
type
#1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the range of the hue slider in the UUI Color Picker component.
Fixes umbraco/Umbraco-CMS#19620.
PR #1076 added nullable fallbacks for the
max
value for the different types, (ref). Which for thehue
type doesn't account for the initialmax
value of100
, meaning it wouldn't fallback to360
by default.The previous implementation fixed the
max
value to360
, so I've reverted the code to this.Types of changes
How to test?
Open a Color Picker component, in the hue slider, extend to over a value of
100
, so that you can scroll through the spectrum of colours (from red to red).