-
Notifications
You must be signed in to change notification settings - Fork 52
Fix bug text character length validation should be more helpful #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1/contrib
Are you sure you want to change the base?
Fix bug text character length validation should be more helpful #1060
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1060.westeurope.azurestaticapps.net |
Hi @NguyenThuyLan. It's great to see some problem solving. I'm thought concerned about replicating any of our Localization Argument handling in UI Library. The Localization In the CMS both supports {0} and %0% and JS Methods
In general it is dangerous to have one system assuming support of another, in this case CMS sending in Localization Strings to the UI Library assuming that UI Library supports the same. Instead we should implement this in a way that enables the CMS to be the sole owner of the Localization mechanism, and we can do so by using the technique I described on another PR: Practically, it will look like this:
|
…to v1/fix-bug/text-character-length-validation
…/github.com/umbraco/Umbraco.UI into v1/fix-bug/text-character-length-validation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1060.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1060.westeurope.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
apporach looks good, so I marked it as ready for review |
Description
Types of changes
After fix:

