-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Specific input mode similar to input type #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
|
Description
Similar to input type, I have added specific values for input mode instead of accepting any string:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode
It seems browsers should use
text
as default input mode. Not sure if that is the case with e.g.type="number"
.Alternatively I think
_inputMode
can be optional and allow undefined, but withoutundefined
as accepted value inInputMode
enum.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist