-
Notifications
You must be signed in to change notification settings - Fork 21
Add IStorageProvider implementation based on IFileProvider #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ronaldbarendse
wants to merge
11
commits into
develop
Choose a base branch
from
feature/storageprovider
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P.NET Core IFileProvider
2 tasks
These are just some idea's that came up recently related to reworking the file providers:
|
Any chance this will continued? It seems related with an performance issue several users are experiencing in different versions of Umbraco (including 15). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #11 (comment).
Instead of wrapping the media
IFileSystem
(Umbraco's read/write IO abstraction) as anIFileProvider
(ASP.NET Core read-only IO abstraction) to then use in theStaticFileMiddleware
, this directly implements theIFileProvider
for the read-only part and exposes the write-operations in a newIStorageProvider
abstraction.This is a POC and still needs a lot of work!