Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type References UI: Workspace + Delete #18914

Open
wants to merge 22 commits into
base: v15/task/align-data-type-reference-endpoint-and-model
Choose a base branch
from

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Apr 2, 2025

The PR is built on #18905 - Please review first

This PR updates the Data Type workspace references app to align with Document, Media, and Member, plus it displays references when deleting a data type.

Updated UI in workspace:
Screenshot 2025-04-02 at 13 37 23

Updated UI for delete dialog:
Screenshot 2025-04-02 at 13 37 47

@nielslyngsoe
Copy link
Member

I just want to add that UI looks good and I skimmed the code and it looks good as well. So if anyone else likes to review that it actually works as expected then I'm happy.

@nielslyngsoe nielslyngsoe removed their request for review April 3, 2025 14:14
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it out and both features - the references on delete and the paged list on the info workspace view - are working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants