Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/unity 1542 pose recorder scene grab ball disconnected and simple interaction glow spams log #1668

Conversation

MaxPalmer-UH
Copy link
Contributor

@MaxPalmer-UH MaxPalmer-UH commented Jan 20, 2025

Summary

Quick fixes to the pose recorder scene and grab ball.

  1. Grab ball has lost it's parent / transform target, so doesn't move the panel.
  2. SimpleInteractionGlow spams the console with NullReferenceExceptions.

On

  1. I've restored the parent.
  2. I've disabled the SimpleInteractionGlow script so it's not spamming.

There is another issue - you can easily push the button off its panel and it flies away, but it can be used.

Contributor Tasks

  • Create or edit test cases here
  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.

Test Cycle

Link to the test cycle here.

Reviewer Tasks

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • All tests must be ran and cover all scenarios (If not, add new tests to the cycle and run them).
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Related JIRA Issues

If this MR closes any JIRA issues list them below in the form Closes PROJECT-#

Pull Request Templates

Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.

You are currently using: default.md

Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with &template=name.md instead of using the link. See query parameter docs for more information.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…amming the log)
@MaxPalmer-UH MaxPalmer-UH changed the base branch from develop to release/7.2.0 January 20, 2025 12:24
Updated changelog.
@MaxPalmer-UH MaxPalmer-UH changed the title Bug/unity 1542 pose detection scene grab ball disconnected and simple interaction glow spams log Bug/unity 1542 pose recorder scene grab ball disconnected and simple interaction glow spams log Jan 20, 2025
…on X,Y,Z for Record Pose Button RigidBody
@MaxPalmer-UH
Copy link
Contributor Author

OK, I've fixed the button falling through the panel and flying away.

Base automatically changed from release/7.2.0 to main January 21, 2025 10:52
@MaxPalmer-UH
Copy link
Contributor Author

@rblenkinsopp @MattFiler this should be ready for review again.

…l_Disconnected_And_SimpleInteractionGlow_Spams_Log
@rblenkinsopp rblenkinsopp self-assigned this Feb 20, 2025
@rblenkinsopp rblenkinsopp merged commit 7f11cbf into main Feb 20, 2025
@rblenkinsopp rblenkinsopp deleted the bug/UNITY-1542_Pose_Detection_Scene_Grab_Ball_Disconnected_And_SimpleInteractionGlow_Spams_Log branch February 20, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants