Skip to content

Conversation

@aguilbau
Copy link

@aguilbau aguilbau commented Dec 9, 2025

No color is currently set when battery is discharging and good threshold is met. This patch fixes it, applying color_good in this case.

@aguilbau aguilbau closed this Dec 9, 2025
@aguilbau aguilbau reopened this Dec 9, 2025
Copy link
Contributor

@lasers lasers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This possibly change behavior / user expectations.

I don't use this module, but if I'm seeing green color, I know my battery is charged / full. If I see a number (color default), I know my battery is decharging / still good, but not full, and not in degraded/bad state yet.

It seems like this (color default) would occur most of the time, so it's not always full. I worry that this is not what users want... because of possible annoyances such as seeing green all times... or seeing green all times, then suddenly yellow without seeing (color default). Users would not see (color default) battery percent anymore.

  1. We need some feedback from users on this.
  2. Switching to thresholds config probably would solve this.

@aguilbau
Copy link
Author

I think this PR can be closed.
I have non default color, and I use it for charging / decharging with a good threshold / fully charged. I could not get it to work without this patch, because I didn't know I could configure default color in a general block ; after doing so, I have the colors I wanted. Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants