Annotation Improvement

[Romakita]

Hello ulfryk,
I'd just fix a bug on my code but I had to fix some bugs on your package.json and bower.json :

• Your package doesn't work with Angular 1.5 (or 1.5 is bugged)
• Your version of Karma is bugged too. Change version fix them.

I didn't write more unit test because I don't like CoffeeScript :) but a thinks you can write test. The added features isn't very complicated and you know this language better than me !

I think, the TSHint configuration is a best practice, but this configuration is too strict to encourage a developer to work on your component :/ (I waist 1 hour just for fix my with TSHint ... XD )

Best regards :)

Romain

[ulfryk]

I think that static link member should be actually moved o@directive decorator in this example.

[Romakita]

I think isn't a best practice to declare a function into an annotation. I never see that in Java.

But I think, effectivily, the description isn't clear...

[ulfryk]

I think isn't a best practice to declare a function into an annotation.

Totally agree. That is why I decided to move the configuration to static members, not to annotation.

Problem is that this linking function must be in this example in annotation, or it will not work at all…

[Romakita]

I think work fine because have these instructions (line 116 - 125) :

config = <IDirectiveProperties> angular.copy(directiveSettings);

// Store FuncName as ControllerAs
config.controllerAs = getFuncName(target);
config.controller = target;

angular.forEach(directiveProperties, function(property: string): any {
    if (angular.isDefined(target[property])) {
       config[property] = target[property];
    }
})

Link method will be stored in config object.

[ulfryk]

You are totally right. I focused on a if (typeof directiveSettings === 'string') { guard and didn't notice the part in lines 122 - 126.

So my observation is invalid.

Now I see - there is another issue. Look down to those lines…

[Romakita]

Hello Ulfryk,

Did you see my last update ?

[ulfryk]

@Romakita - sorry for delay, I have a lot of hard work with other things. Just give me few days ;)

[ulfryk]

1.5.2 maybe ?

[Romakita]

Maybe. 1.5 give me an error.

[ulfryk]

Ok leave it on 1.4 I'll fix errors and upgrade deps later.

[ulfryk]

@Romakita - sorry for delay - just few last fixes :)