Open
Conversation
…r central coil visualization
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4136 +/- ##
==========================================
- Coverage 47.84% 47.78% -0.06%
==========================================
Files 141 141
Lines 29754 29791 +37
==========================================
+ Hits 14236 14237 +1
- Misses 15518 15554 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… add plasma image visualization
…d negative x-axis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for mirroring the poloidal cross-section plots of various tokamak components to the negative x-axis, enabling full machine symmetry in visualizations. This is achieved by introducing a
mirror_negative_xparameter to the relevant plotting functions and applying a transformation to the x-coordinates when this option is enabled. Additionally, a new convenience function is added to plot the full machine cross-section including all mirrored components.Major changes:
Mirroring support for plotting functions
Added a
mirror_negative_xboolean parameter (defaultFalse) to the following functions:plot_plasma,plot_centre_cross,plot_vacuum_vessel_and_divertor,plot_shield,plot_blanket,plot_firstwall, andplot_cryostat. When enabled, these functions now mirror the plot to the negative x-axis by multiplying x-coordinates by -1.Updated the implementation of these plotting functions to apply the x-axis mirroring transformation (
x_scale) wherever x-coordinates are used, ensuring all plotted elements are correctly mirrored when requested.New full cross-section plotting function
plot_full_machine_poloidal_cross_sectionthat plots the entire machine cross-section, including all major components (vessel, shield, blanket, first wall, plasma, coils, cryostat, etc.) and their mirrored counterparts, using the updated plotting functions with themirror_negative_xflag.Documentation improvements
mirror_negative_xparameter and its effect.These changes enhance the flexibility and completeness of the plotting utilities, making it easier to visualize the full symmetric geometry of the machine for analysis and presentations.## Description
Checklist
I confirm that I have completed the following checks: