Conversation
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
Few comments, you also need to update the docs and give a reference. Please put the reference in IEEE style with a hyperlink DOI
| # Output file naming | ||
| if output_name == "plasma_current_MA": | ||
| extra_str = f"plasma_current{f'_vs_{output_name2}' if output_names2 != [] else ''}" | ||
| if output_name == "p_div_separatrix_max_mw/physics_variables.rmajor": |
There was a problem hiding this comment.
This shouldnt be needed in this from now as there is now physics_variables.p_plasma_separatrix_rmajor_mw
process/input.py
Outdated
| ), | ||
| "fiooic": InputVariable( | ||
| data_structure.constraint_variables, float, range=(0.001, 1.0) | ||
| data_structure.constraint_variables, float, range=(0.001, 10.0) |
There was a problem hiding this comment.
Why has this been changed?
| data_structure.pfcoil_variables, float, range=(0.0, 1e-05) | ||
| ), | ||
| "rinboard": InputVariable(data_structure.build_variables, float, range=(0.1, 10.0)), | ||
| "routboard": InputVariable(data_structure.build_variables, float, range=(0.1, 20.0)), |
There was a problem hiding this comment.
Why has this been added? Is it a new variable
process/input.py
Outdated
| ), | ||
| "i_fw_blkt_vv_shape": InputVariable( | ||
| data_structure.fwbs_variables, int, range=(1, 2) | ||
| data_structure.fwbs_variables, int, range=(1, 3) |
|
|
||
| if physics_variables.i_plasma_geometry == 12: | ||
|
|
||
| physics_variables.kappa = 2.93e0 * ( 1.8e0 / physics_variables.aspect ) ** 0.4e0 |
There was a problem hiding this comment.
A comment with the model origin needs to be added
| elif physics_variables.i_plasma_geometry == 12: | ||
| po.ovarrf( | ||
| self.outfile, | ||
| "Elongation, X-point (calculated from aspect ratio via scaling)", |
There was a problem hiding this comment.
The string needs to state the model
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
Thanks @chris-ashe for the review. @ajpearcey please fix the merge conflicts so that the CI can run and I can review any failures there
3 participants
add new relationship for elongation v aspect ratio. Validated for low aspect ratio ST devices.