fix(auth): throw error when auth env vars are missing #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@chetan2332 thanks for the PR. I've added some comments. Also, would you mind if I add some test cases for that straight in this PR? |
Contributor
Author
|
Yes, pls feel free to add the test cases. |
mauriciolauffer
requested a deployment
to
external
GitHub Actions
Waiting
Contributor
|
@chetan2332 tests added. Thanks :) |
Contributor
|
thanks a lot for the PR @chetan2332! This is excellent "get it done" mentality :) |
Contributor
Author
|
Hi @vobu, tests are passing locally but failing in CI/DC with waitAsync is already running timeout errors. Increased waitForUI5Timeout to 30s as a workaround - is this the recommended approach? |
mauriciolauffer
added a commit
to mauriciolauffer/wdi5
that referenced
this pull request
Nov 5, 2025
) [skip ci] * fix(auth): throw error when auth env vars are missing * test: add test case for missing username and password in auth class * fix(test): increased UI5 timeout --------- Co-authored-by: Chetan Mahajan <[email protected]> Co-authored-by: Mauricio Lauffer <[email protected]>
mauriciolauffer
added a commit
to mauriciolauffer/wdi5
that referenced
this pull request
Nov 6, 2025
) [skip ci] * fix(auth): throw error when auth env vars are missing * test: add test case for missing username and password in auth class * fix(test): increased UI5 timeout --------- Co-authored-by: Chetan Mahajan <[email protected]> Co-authored-by: Mauricio Lauffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #695